Add phpunit and update deps. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
composer.json Outdated
There was a problem hiding this comment.
you can just also do ~3.7
There was a problem hiding this comment.
or 3.7.* since PHPUnit tends to break stuff in minor versions.
| wonder if we could ignore composer.lock in this case |
| @cordoval why? |
| @igorw just because 👶 it helps reviewing the code better and take auto-generated things out of the way |
| @igorw Merge pahty? ;) (Also, I will probably be at Redwood Bar tonight. =) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.