Skip to content

feat: move action icon into URL bar #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: move action icon into URL bar #20

wants to merge 1 commit into from

Conversation

@jceb
Copy link
Member

@jceb jceb commented Feb 7, 2024 •
edited
Loading

Closes #10

I'm not sure about this change since a) Chrome doesn't support icons in the URL bar :-/ and b) Firefox doesn't seem to support the full color palette as one can see on the screenshots.

Firefox:

image

Chrome:

image
@jceb jceb requested a review from simne7 February 7, 2024 09:36
@jceb jceb self-assigned this Feb 7, 2024
@simne7
Copy link
Contributor

simne7 commented Feb 7, 2024

Hm 🤔

  • we could adjust the color palette for FF. your screenshot shows at least some red and blue icons... but for a good UX at least some red, orange, green, and gray palette should be possible
  • as Chrome does not support it at all: should we probably stay with what we have to keep a consistent UI across browsers? Helps us as devs (less code to maintain) and users using both browsers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jceb @simne7