Add Record rule #300
Merged
Add Record rule #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
erfanium approved these changes Jul 25, 2022
Collaborator
erfanium left a comment
erfanium left a comment There was a problem hiding this comment.
It looks good to me, btw i haven't contributed to this project for more than a year, I don't have a good mind on codes
icebob requested changes Aug 3, 2022
Owner
icebob left a comment
icebob left a comment There was a problem hiding this comment.
Awesome, please add passed tests as well, not just negative tests.
Owner
Could you make it? |
Contributor Author
Yes, of course. I just have a lot of work and can only make small changes. When I add tests I'll let you know ;) Today or tomorrow, I think |
Owner
| Ok, take your time. Just I plan to make a new release in the next days and I would like to add it to the next version. But I will wait it :) |
Contributor Author
| @icebob done;) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I added a new
recordrule. I decided to userecordinstead ofmapbecause it can be confused with an nativeMapobject.If everything is ok, I'll improve tests and add docs.
Related issue #276