fix: count instances of runmqdevserver correctly on M1 macs #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adamdecaf force-pushed the inspect-running-processes-better branch from c332a3f to a9784de Compare 
ydnar reviewed May 4, 2023
With emulation runmqdevserver appears multiple times in a single line of `ps` output, so we need to count the number of lines with runmqdevserver instead. Issue: ibm-messaging#476
adamdecaf force-pushed the inspect-running-processes-better branch from a9784de to 880d242 Compare 
leki75 reviewed Jun 7, 2023
| out, _, _ := command.Run("ps", "-e", "--format", "cmd") | ||
| //if this goes wrong then assume we are the only one | ||
| numOfProg := strings.Count(out, programName) | ||
| lines := strings.Split(out, "\n") |
There was a problem hiding this comment.
I think it would be easier to change cmd to comm instead.
There was a problem hiding this comment.
The --format cmd will actually list the command with arguments (it is an alias to args), while comm will only list the binary without arguments.
See: https://man7.org/linux/man-pages/man1/ps.1.html#STANDARD_FORMAT_SPECIFIERS
There was a problem hiding this comment.
Can confirm that simply switching to comm format should give the desired result:
sh-4.4$ runmqdevserver > /dev/null 2>&1 & [1] 58 sh-4.4$ ps -e --format comm COMMAND sh runmqdevserver ps sh-4.4$ ps -e --format cmd CMD /usr/bin/qemu-x86_64 /bin/sh /bin/sh /usr/bin/qemu-x86_64 /usr/local/bin/runmqdevserver runmqdevserver ps -e --format cmd There was a problem hiding this comment.
Thanks. I've opened a new PR with the simpler fix #527
adamdecaf added a commit to adamdecaf/mq-container that referenced this pull request Jun 9, 2023
During emulation the running processes can contain binary names which trip up detecting if a process is already running. Using the comm format will print the running binaries without arguments. Previous: ibm-messaging#524 Issue: ibm-messaging#476
JEFFLUFC pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With emulation runmqdevserver appears multiple times in a single line of
psoutput, so we need to count the number of lines with runmqdevserver instead.Thanks to @master131 for finding this fix.
Issue: #476