Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Conversation

@davidkel
Copy link

@davidkel davidkel commented Dec 4, 2018

This doesn’t fix it for any other logging as all trace points
in composer-runtime will need to be changed, also somehow
the context would have to be passed to apis in composer-common
as well.

Signed-off-by: Dave Kelsey d_kelsey@uk.ibm.com

This doesn’t fix it for any other logging as all trace points in composer-runtime will need to be changed, also somehow the context would have to be passed to apis in composer-common as well. Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com>
Copy link
Contributor

@mahoney1 mahoney1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lesleyannjordan lesleyannjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments

@davidkel davidkel added the P2 label Dec 4, 2018
@davidkel davidkel merged commit 4cc9d5a into hyperledger-archives:master Dec 4, 2018
@davidkel davidkel deleted the FixRuntimeLogging-Master branch December 4, 2018 21:04
@davidkel
Copy link
Author

davidkel commented Dec 5, 2018

#4518 is the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4 participants