This repository was archived by the owner on Mar 8, 2020. It is now read-only.
[master] Explain how CAs are configured for TLS in the connection profile reference #4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Björn Tegelund <b.tegelund@gmail.com>
davidkel reviewed Oct 18, 2018
| "ca.org1.example.com": { | ||
| "url": "https://ca.org1.example.com:7054", | ||
| "caName": "ca.org1.example.com", | ||
| "http": { |
There was a problem hiding this comment.
could you change 'http' to 'httpOptions' as this is the correct name
davidkel suggested changes Oct 18, 2018
davidkel left a comment
davidkel left a comment There was a problem hiding this comment.
Hi, Thanks for the submission, just a minor change required.
Signed-off-by: Björn Tegelund <b.tegelund@gmail.com>
Contributor Author
| @davidkel Sorry about that. Fixed the typo. |
davidkel approved these changes Oct 20, 2018
| LGTM. Thanks for the contribution |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed that orderers and peers have additional explanations for how to configure the connection profile when using TLS, but this is not present for Certificate Authorities. This commit adds such info. It also changes a broken link to the Fabric Node SDK to point readers to the closest related page.