This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Enable deletion of model and script files #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cazfletch reviewed May 17, 2017
| <svg class="ibm-icon" aria-hidden="true"> | ||
| <use xlink:href="#icon-warn_32"></use> | ||
| </svg> | ||
| <h1 [innerHTML]="headerMessage"></h1> |
cazfletch reviewed May 17, 2017
| <div class="item"><b>{{fileType}}</b></div> | ||
| <div class="item"><i>{{fileName}}</i></div> | ||
| </section> | ||
| <p [innerHTML]="deleteMessage"></p> |
Contributor
There was a problem hiding this comment.
this should also be {{}}
cazfletch reviewed May 17, 2017
| </section> | ||
| </section> | ||
| <footer> | ||
| <button type="button" class="secondary" (click)="activeModal.close(false)">Cancel</button> |
Contributor
There was a problem hiding this comment.
you could use activeModal.dismiss() here rather than close
cazfletch reviewed May 17, 2017
| display: flex; | ||
| flex-direction: column; | ||
| align-content: flex-start; | ||
| margin-left: 2rem; |
Contributor
There was a problem hiding this comment.
this should use a variable i think 2rem (32px) is $space-large
Contributor Author
There was a problem hiding this comment.
sure - the $space items appear to all be in px sizing, but change made
Contributor
There was a problem hiding this comment.
they are, they need updating
cazfletch reviewed May 17, 2017
| border-left: solid $first-highlight; | ||
| | ||
| .item{ | ||
| margin-left: 1rem; |
Contributor
There was a problem hiding this comment.
This should use a variable too think 1rem (16px) is $space-medium
cazfletch reviewed May 17, 2017
| beforeEach(() => { | ||
| TestBed.configureTestingModule({ | ||
| declarations: [DeleteComponent], | ||
| providers: [NgbActiveModal] |
Contributor
There was a problem hiding this comment.
should NgbActiveModal be mocked or do you use it in the tests?
cazfletch reviewed May 17, 2017
| </svg> | ||
| </button> | ||
| </div> | ||
| <div *ngIf="deletableFile" style="flex-shrink:1;align-self:center; margin-left: auto"> |
Contributor
There was a problem hiding this comment.
the style bits should be in the scss file
cazfletch suggested changes May 17, 2017
Contributor
cazfletch left a comment
cazfletch left a comment There was a problem hiding this comment.
Made some comments of things for you to look at
* Updates for work * Adding Installing Index to ToC * Removing Fabric Composer name * Removing Fabric composer name * Moving images for REST API doc * Fabric Composer Name removal * Fabric Composer name removal * Other name changes (Stack Overflow, GitHub, Rocket.Chat, JavaScript) * wording updates and bug splats * ToC Updates * HLv1 docs updates, couple more bug splats. * Last edit for HLv1 * Whoops, bug splat * Another bug splat... * Quick fixes prereqs navbar * intro diagram fix and bug fixes * Fixes and updates * Rollback optional script for v1.0 * QoL changes and rollback changes - Quickstart * Link fixes * Atom links fix, formatting fix * Odd formatting fix. * Name change and codeblock fix * More odd formatting fixes * Ubuntu root user doc fix + draft of bnd doc changes * update for CLI define + deploy BNA * last bnd update * Events and bug fixes * Last event thing * Updates for #803 and hyperledger-archives#822 * removing unnecessary stuff * Undeploy support #673 * Clarifications on undeploy
…into delete-files
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Code delivery for #386, provides the ability for a user to delete model and/or script files
Delivers:
Design of the fix
Follows user flow of named user story.
Modal confirmation enables deletion of named file within business network.
Validation of all business network files enabled and now all files must validate before enabling deploy
Validation of the fix
manual testing
Automated Tests
Automated tests established for new additions driving expected component actions.