[DO NOT MERGE] Add Crop Transformation #22608
Open
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Abstracts out cropping logic to be a more generic
cropfunction which other, more specific cropping functions e.g.center_cropcan call.Motivation:
topandleftcoordinates were calculated resulting in some values being off by one.cropmethod enables each image processor to have its own center_crop logic with minimal code replication.[BEFORE MERGING]: Verify this doesn't have large impact on any popular CLIP dependant pipelines
Fixes #22505
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.