Fixed type error when req.socket is undefined #1634
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When req.socket is undefined a type error occured, this error is fixed within this pull request. Fixed error - uncaughtException: TypeError: Cannot read properties of undefined (reading 'destroyed')
cloetensbrecht changed the title 
24 tasks
| Hey, good morning. I took the liberty of making a fork with almost 500 issues and 100 pull requests applied. If you want to check it out: https://github.com/squarecloudofc/http-proxy |
Denoder added a commit to refactorjs/http-proxy that referenced this pull request Oct 22, 2023
Added Pull Request from: - http-party/node-http-proxy#1634 - http-party/node-http-proxy#1638 - http-party/node-http-proxy#1650 fix tests that were having issues with the ports (if it fails the tests needs to be reran, seems to be an async issue)
ravin00 approved these changes Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When req.socket is undefined a type error occured, this error is fixed within this pull request. Fixed error - uncaughtException: TypeError: Cannot read properties of undefined (reading 'destroyed')