Skip to content

[dist] Update dependency ws to v3 [SECURITY] #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 22, 2019
Merged

[dist] Update dependency ws to v3 [SECURITY] #1361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a312861
[dist] Update dependency ws to v3 [SECURITY]
renovate-bot Aug 22, 2019
73613d2
[dist] End of an era.
indexzero Aug 22, 2019
0a54df2
[dist] New test fixtures.
indexzero Aug 22, 2019
8887d07
[dist] .gitattributes all the things.
indexzero Aug 22, 2019
cf1f26a
[dist] Regenerate package-lock.json.
indexzero Aug 22, 2019
a9eaf25
[fix test] Update tests.
indexzero Aug 22, 2019
4241a39
[fix] Latest versions.
indexzero Aug 22, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[fix test] Update tests.
  • Loading branch information
@indexzero
indexzero committed Aug 22, 2019
commit a9eaf25754ecaaeaefd8a98b1ce12dd414b2566f
4 changes: 2 additions & 2 deletions test/lib-http-proxy-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,8 @@ describe('lib/http-proxy.js', function() {
});
});

destiny.on('connection', function (socket) {
expect(socket.upgradeReq.headers['x-special-proxy-header']).to.eql('foobar');
destiny.on('connection', function (socket, upgradeReq) {
expect(upgradeReq.headers['x-special-proxy-header']).to.eql('foobar');

socket.on('message', function (msg) {
expect(msg).to.be('hello there');
Expand Down
2 changes: 1 addition & 1 deletion test/lib-https-proxy-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ describe('lib/http-proxy.js', function() {
proxy.on('error', function (err, req, res) {
expect(err).to.be.an(Error);
if (semver.gt(process.versions.node, '0.12.0')) {
expect(err.toString()).to.be('Error: self signed certificate')
expect(err.toString()).to.be('Error: unable to verify the first certificate')
} else {
expect(err.toString()).to.be('Error: DEPTH_ZERO_SELF_SIGNED_CERT')
}
Expand Down