Add testcase for open attribute value #140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a curious testcase because html5ever appears to be failing it. At least piping it to html5ever like so appears to produce: ``` $ cargo run -p html5ever --example tokenize < ~/projects/html5gum/fuzz/mintest Finished dev [unoptimized + debuginfo] target(s) in 0.04s Running `target/debug/examples/tokenize` ERROR: Bad character TAG : <d 0='&0=''> CHAR : "\n" OTHER: EOFToken Tokenizer profile, in nanoseconds 31248 total in token sink 43594 total in tokenizer 24126 55.3% AttributeValue(Unquoted) 7133 16.4% Data 4389 10.1% TagOpen 2986 6.8% SelfClosingStartTag 1363 3.1% BeforeAttributeValue 1283 2.9% BeforeAttributeName 1162 2.7% TagName 1152 2.6% AttributeName ``` I could not find an older revision of the spec (in w3 or whatwg) that would explain this behavior. It's late and I'm tired, but I believe my reading of the spec is correct and this should not emit a tag.
Contributor Author
| Forgot to mention, I'm running afl to find inconsistencies between html5gum and html5ever now. This is why I decided to create a separate file, to not clutter existing files as I add more to this. Do you think this belongs in one of the existing files? |
Contributor Author
| I believe this testcase may add nothing new to the testsuite. I assumed it would be non-overlapping with existing testdata because it exhibits flaws in html5ever, however html5ever is lagging 4 years behind testsuite's main branch, see servo/html5ever#459 Not sure what to do with this or how to best check that this testcase adds something new. |
Contributor Author
| Nevermind, I think this should be covered already. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a curious testcase because html5ever appears to be failing it.
At least piping it to html5ever like so appears to produce:
I could not find an older revision of the spec (in w3 or whatwg) that
would explain this behavior.
It's late and I'm tired, but I believe my reading of the spec is correct
and this should not emit a tag.