Updates for missing features in regular expressions. #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I am still updating the results. |
| All regex related tests are updated. The remaining failures are from other tests. |
| Thanks! As described in #1322, I will need a new one-time CLA that will cover all your future contributions. I've emailed you the new CLA, and one it's completed I can look at PRs. |
| I signed the document. |
| Looks great, thanks Max! |
| Hey, sorry to necromance a pull request, but it looks like you only checked in the .cpp of pure2-regex_20_lookbehind and not the .cpp2. Any chance that could get fixed? |
| Thanks for the hint. I added the file and created a pull request. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added some of the missing features for regular expression.
find_allmethod for the regular expressions.\G.The PR can be squashed into one commit. I left the commits for better review granularity.