- Notifications
You must be signed in to change notification settings - Fork 264
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
#248 (comment) finally pushed to comment on this. This formulation:
- Passes fundamental types of size greater than 2 object pointers, like some 256-bit extended integer type.
- Introduces a regression. Types that are not fundamental due to ABI issues, like GCC's 128-bit integer types (
-pedantic), are passed byconst&.I suggest reverting the deletion of
prefer_pass_by_valueand enhancing it to exclude the problematic incomplete types that can affectcpp2::in.
Also fix < to <= to consider types exactly the size of 2 object pointers. See https://compiler-explorer.com/z/8EKPMrhee.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working