Skip to content

Conversation

@jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Apr 17, 2021

Upgrade @commitlint/prompt (and other @committlint depependencies) which seems to fix the broken commit script (#381).

@jrolfs jrolfs self-assigned this Apr 17, 2021
@jrolfs jrolfs requested review from EvaFro and kang April 17, 2021 23:22
@jrolfs jrolfs changed the title 🐛 Upgrade @commitlint to ffix commit script" 🐛 Upgrade @commitlint to fix commit script" Apr 17, 2021
@github-actions github-actions bot force-pushed the fix/commit-script branch from 0ad7eae to 34ac0a5 Compare April 17, 2021 23:22
@jrolfs jrolfs changed the title 🐛 Upgrade @commitlint to fix commit script" 🐛 Upgrade @commitlint to fix commit script Apr 17, 2021
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #401 (34ac0a5) into main (ca32c89) will decrease coverage by 0.64%.
The diff coverage is n/a.

❗ Current head 34ac0a5 differs from pull request most recent head 145b85e. Consider uploading reports for the commit 145b85e to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## main #401 +/- ## ========================================== - Coverage 94.47% 93.82% -0.65%  ========================================== Files 26 26 Lines 344 324 -20 Branches 61 66 +5 ========================================== - Hits 325 304 -21  - Misses 17 19 +2  + Partials 2 1 -1 
Impacted Files Coverage Δ
src/config/jest.config.js 78.57% <0.00%> (-14.29%) ⬇️
src/run-script.js 94.87% <0.00%> (-0.13%) ⬇️
src/scripts/validate.js 100.00% <0.00%> (ø)
src/scripts/pre-commit.js 100.00% <0.00%> (ø)
src/scripts/ci-after-success.js 100.00% <0.00%> (ø)
src/utils.js 88.00% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca32c89...145b85e. Read the comment docs.

@jrolfs jrolfs added the automerge dd this label to any PRs that you want merged as soon as CI passes label Apr 17, 2021
@jrolfs jrolfs force-pushed the fix/commit-script branch from d43f5be to 145b85e Compare April 17, 2021 23:27
@jrolfs jrolfs merged commit a733c7d into main Apr 17, 2021
@jrolfs jrolfs deleted the fix/commit-script branch April 17, 2021 23:38
@jrolfs
Copy link
Collaborator Author

jrolfs commented Apr 17, 2021

🎉 This PR is included in version 5.36.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge dd this label to any PRs that you want merged as soon as CI passes released

2 participants