π Fix argument forwarding for commit-msg script #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot force-pushed the fix/commit-msg-arguments branch from 676a7b4 to 22e2c91 Compare 
Codecov Report
@@ Coverage Diff @@ ## main #395 +/- ## ======================================= Coverage 93.82% 93.82% ======================================= Files 26 26 Lines 324 324 Branches 66 66 ======================================= Hits 304 304 Misses 19 19 Partials 1 1
Continue to review full report at Codecov.
|
fiddlerwoaroof approved these changes Apr 12, 2021
github-actions bot force-pushed the fix/commit-msg-arguments branch from 22e2c91 to 482fce1 Compare 
jrolfs force-pushed the fix/commit-msg-arguments branch from 55cb408 to ed969b8 Compare github-actions bot force-pushed the fix/commit-msg-arguments branch from ed969b8 to a2b1db8 Compare - Fixes use case of actually passing `--edit $1` for example - Also fixes passing a custom config via `--config`
Defaults to passing `--edit` with no value to **commitlint** when no arguments are passed.
github-actions bot force-pushed the fix/commit-msg-arguments branch from a2b1db8 to b7d6e07 Compare 
| π This PR is included in version 5.41.0 π The release is available on:
Your semantic-release bot π¦π |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Arguments weren't actually being forwarded to @commitlint/cli... missed this due to snapshot based tests βΉ.
--edit $1for example--config⨠Also support Husky 6 by defaulting to
--editwhen no arguments are passed.