Skip to content

Conversation

@jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Oct 6, 2020

This gets us the allowAsStatement option on the no-void rule which is currently set and therefore breaking the configuration :(

@jrolfs jrolfs self-assigned this Oct 6, 2020
@jrolfs jrolfs requested a review from aarosil October 6, 2020 20:26
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #275 +/- ## ======================================= Coverage 89.24% 89.24% ======================================= Files 25 25 Lines 372 372 Branches 86 86 ======================================= Hits 332 332 Misses 33 33 Partials 7 7 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d71dd...a6fb4b2. Read the comment docs.

@jrolfs jrolfs merged commit 68f5040 into master Oct 6, 2020
@jrolfs jrolfs deleted the build/upgrade-eslint branch October 6, 2020 20:33
@jrolfs
Copy link
Collaborator Author

jrolfs commented Oct 6, 2020

🎉 This PR is included in version 4.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jrolfs jrolfs added the released label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants