Include hidden elements for turbo-cable-stream-source selector #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
seanpdoyle reviewed May 29, 2025
excid3 force-pushed the assert-visible-turbo-cable-stream-sources branch from 6ee2370 to d78525c Compare seanpdoyle reviewed May 29, 2025
seanpdoyle approved these changes May 29, 2025
Chrome considers these elements not visible (likely due to their 0px size) so the assertion never matches. This changes the default visible flag to include all elements. Co-authored-by: Sean Doyle <seanpdoyle@users.noreply.github.com>
excid3 force-pushed the assert-visible-turbo-cable-stream-sources branch from c0e3025 to 80fb337 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Chrome considers these elements not visible (likely due to their 0px size) so the assertion never matches. This changes the default visible flag to include all elements.
cc @seanpdoyle