Skip to content

Raise exception when no id is passed to the turbo_frame_tag helper #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Raise exception when no id is passed to the turbo_frame_tag helper #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eab3786
Handle nil and empty values on turbo_frame_tag
thiagopradi Jan 8, 2024
c05e580
Update app/helpers/turbo/frames_helper.rb
thiagopradi Jan 8, 2024
f235389
Merge remote-tracking branch 'hotwired-turbo-rails/main'
thiagopradi Feb 25, 2024
8e4a85f
Ops, reverting bad merge
thiagopradi Feb 25, 2024
3f68bc3
Ops, reverting bad merge #2
thiagopradi Feb 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/helpers/turbo/frames_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,13 @@ module Turbo::FramesHelper
#
# <%= turbo_frame_tag(Article.find(1), "comments") %>
# # => <turbo-frame id="comments_article_1"></turbo-frame>
#
# Raises an +ArgumentError+ if called without a frame id.
# <%= turbo_frame_tag(nil) %> # => ArgumentError: You must supply a frame id
def turbo_frame_tag(*ids, src: nil, target: nil, **attributes, &block)
id = ids.first.respond_to?(:to_key) ? ActionView::RecordIdentifier.dom_id(*ids) : ids.join('_')
raise ArgumentError, "You must supply a frame id" if ids.all?(&:blank?)

id = ids.first.respond_to?(:to_key) ? ActionView::RecordIdentifier.dom_id(*ids) : ids.join("_")
src = url_for(src) if src.present?

tag.turbo_frame(**attributes.merge(id: id, src: src, target: target).compact, &block)
Expand Down
20 changes: 20 additions & 0 deletions test/frames/frames_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,26 @@ class Turbo::FramesHelperTest < ActionView::TestCase
assert_dom_equal %(<turbo-frame id="message_1"></turbo-frame>), turbo_frame_tag(record)
end

test "frame with invalid argument should raise ArgumentError" do
Copy link
Contributor

@brunoprietog brunoprietog Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The record variables could be ignored here and pass the argument directly. I don't see much value in declaring them
assert_raises ArgumentError, "ArgumentError: You must supply a frame id" do
record = nil

turbo_frame_tag(record)
end

assert_raises ArgumentError, "ArgumentError: You must supply a frame id" do
record = []

turbo_frame_tag(record)
end

assert_raises ArgumentError, "ArgumentError: You must supply a frame id" do
record = ''

turbo_frame_tag(record)
end
end

test "string frame within a model frame" do
record = Article.new(id: 1)

Expand Down