Skip to content

Conversation

@wendevlin
Copy link
Member

Proposed change

  • Use ha-dropdown for automation and script editor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin marked this pull request as draft December 3, 2025 11:51
@wendevlin
Copy link
Member Author

Switched to draft as I want to use wa-dropdowns value attribute instead of data-action

@wendevlin wendevlin marked this pull request as ready for review December 3, 2025 12:08
Copilot AI added a commit that referenced this pull request Dec 3, 2025
Updated all migrated files to use value attribute instead of data-action, and ev.detail?.item?.value instead of ev.detail?.item?.dataset?.action in handlers, following the updated pattern from reference PR #28293. Co-authored-by: wendevlin <12148533+wendevlin@users.noreply.github.com>
Copy link
Contributor

@uptimeZERO uptimeZERO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nicely done! 😁

@uptimeZERO uptimeZERO merged commit 98a1f5c into dev Dec 3, 2025
15 checks passed
@uptimeZERO uptimeZERO deleted the use-ha-dropdown-for-automations branch December 3, 2025 13:33
Copilot AI added a commit that referenced this pull request Dec 4, 2025
- Migrate ha-config-logs.ts: Replace ha-button-menu with ha-dropdown for log provider selection - Migrate ha-qr-scanner.ts: Replace ha-button-menu with ha-dropdown for camera selection - Migrate ha-data-table-labels.ts: Replace ha-button-menu with ha-dropdown for overflow labels Following the migration pattern from PR #28293 Co-authored-by: wendevlin <12148533+wendevlin@users.noreply.github.com>
silamon pushed a commit that referenced this pull request Dec 8, 2025
* Initial plan * Migrate ha-button-menu to ha-dropdown in 3 files - Migrate ha-config-logs.ts: Replace ha-button-menu with ha-dropdown for log provider selection - Migrate ha-qr-scanner.ts: Replace ha-button-menu with ha-dropdown for camera selection - Migrate ha-data-table-labels.ts: Replace ha-button-menu with ha-dropdown for overflow labels Following the migration pattern from PR #28293 Co-authored-by: wendevlin <12148533+wendevlin@users.noreply.github.com> * Fix ha-data-table-labels migration to use proper @wa-select pattern - Add HaDropdownItem type import - Use @wa-show instead of @click for menu opening - Use @wa-select for item selection with proper event handler - Update comment to reference ha-dropdown instead of ha-button-menu Co-authored-by: wendevlin <12148533+wendevlin@users.noreply.github.com> * Fixes * Remove unused code * Remove unused styles --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wendevlin <12148533+wendevlin@users.noreply.github.com> Co-authored-by: Wendelin <w@pe8.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants