Skip to content

Conversation

@abmantis
Copy link
Member

Proposed change

This seems to be a leftover when copy-pasting the tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (text) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of text can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign text Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a misplaced alarm control panel test from the text component's trigger tests. The removed test (test_alarm_control_panel_triggers_gated_by_labs_flag) was testing alarm control panel triggers with parameters like "alarm_control_panel.armed", which is unrelated to text entities. This appears to be a leftover from copy-pasting test files during initial setup.

Key Changes

  • Removed the test_alarm_control_panel_triggers_gated_by_labs_flag test function and its parametrization from tests/components/text/test_trigger.py
  • The identical test already exists in the correct location: tests/components/alarm_control_panel/test_trigger.py
@arturpragacz arturpragacz merged commit 0a676b5 into dev Dec 12, 2025
41 of 42 checks passed
@arturpragacz arturpragacz deleted the remove_wrong_test branch December 12, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment