Add diagnostics support for Nederlandse Spoorwegen integration #158722
+264 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hey there @YarmoM, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds diagnostics support to the Nederlandse Spoorwegen integration, enabling users to extract debugging information at both the config entry and device levels. The implementation collects coordinator data, route information, and trip details while properly redacting sensitive API keys.
Key Changes
- Added
diagnostics.pymodule with config entry and device-level diagnostics functions - Created comprehensive test coverage with snapshot assertions
- Implemented proper data redaction for API keys
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
homeassistant/components/nederlandse_spoorwegen/diagnostics.py | Implements diagnostics data collection for config entries and devices, including coordinator info, route data, and trip details with API key redaction |
tests/components/nederlandse_spoorwegen/test_diagnostics.py | Adds test coverage for both entry and device diagnostics with snapshot assertions |
tests/components/nederlandse_spoorwegen/snapshots/test_diagnostics.ambr | Defines expected diagnostic output snapshots for verification |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Breaking change
NO
Proposed change
This adds diagnostics support to the Nederlandse spoorwegen integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: