Skip to content

Conversation

@epenet
Copy link
Contributor

@epenet epenet commented Dec 11, 2025

Proposed change

The current remap methods are confusing:

  • the target range (0-100 in cover, 1-100 in fan, 0-360 / 0-100 / 0-255 / MIN_MIREDS-MAX_MIREDS in light) were passed in both remap_value_from and remap_value_to
  • the light platform was creating fake IntegerTypeInformation classes in order to access the helper method there

This replaces the current methods with a helper class so that:

  • the source/target range is always declared explicitly (no more defaulting to 0-255)
  • the reverse option is a kw-only argument
  • fake IntegerTypeInformation instances are replaced with RemapHelper instances

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Tuya integration's value remapping functionality by introducing a new RemapHelper class to replace the previous confusing methods. The changes improve code clarity by making source and target ranges explicit, converting reverse to a keyword-only argument, and eliminating fake IntegerTypeInformation instances that were previously created just to access helper methods.

Key changes:

  • Introduced RemapHelper dataclass with explicit source/target ranges and factory methods
  • Replaced IntegerTypeInformation.remap_value_to/from methods with RemapHelper instances
  • Made type_data field non-optional in TypeInformation class since it's always provided

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/tuya/util.py Added new RemapHelper dataclass with remap_value_to, remap_value_from, and static remap_value methods; includes factory methods for creating instances from type information or function data
homeassistant/components/tuya/type_information.py Removed remap_value_to and remap_value_from methods from IntegerTypeInformation; changed type_data from optional to required field
homeassistant/components/tuya/light.py Replaced fake IntegerTypeInformation instances with RemapHelper instances for HSV defaults; updated brightness, color temperature, and color data wrappers to use RemapHelper
homeassistant/components/tuya/fan.py Updated _FanSpeedIntegerWrapper to use RemapHelper instance for value remapping
homeassistant/components/tuya/cover.py Updated _DPCodePercentageMappingWrapper to use RemapHelper instance; contains import error (uses .utils instead of .util)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment