PR for v.1.4.3 #126
Merged
PR for v.1.4.3 #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…arginright BUGFIX: #124 ChartOptions.margin and .spacing deserialization
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #126 +/- ## ========================================== - Coverage 88.26% 88.26% -0.01% ========================================== Files 208 208 Lines 30217 30239 +22 Branches 2409 2420 +11 ========================================== + Hits 26671 26690 +19 - Misses 2646 2647 +1 - Partials 900 902 +2
☔ View full report in Codecov by Sentry. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ChartOptionsusing.from_dict()with a
dictthat had been serialized using.to_dict()which errored on.marginand
.spacing(Unable to use chart.marginRight #124).