HV-1429 Incorrect Pax URL syntax for paranamer #803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Incorrect Pax URL syntax for bundle (dependency) com.thoughtworks.paranamer/paranamer
| Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test") |
| @tonit Hi! Thanks for your PR. Could you take the time to add a test in our OsgiIntegrationTest? It's apparently missing :). And could you please sign the CLA for the Hibernate Validator project here: https://cla.jboss.org/ ? Thanks! |
This commit adds a new Pax Exam based test installing both karaf features provided by this project on a vanilla karaf. It highlights the issue found by hibernate#803 but should be extended whenever a new feature is being added to the repo.
| I have just added tests for this. CLA will come.. |
| CLA signed. (tonitcom) |
gsmet pushed a commit that referenced this pull request Jul 7, 2017
This commit adds a new Pax Exam based test installing both karaf features provided by this project on a vanilla karaf. It highlights the issue found by #803 but should be extended whenever a new feature is being added to the repo.
gsmet pushed a commit that referenced this pull request Jul 7, 2017
This commit adds a new Pax Exam based test installing both karaf features provided by this project on a vanilla karaf. It highlights the issue found by #803 but should be extended whenever a new feature is being added to the repo.
| @tonit thanks! I amended the commit messages to include a JIRA issue number and made a few very minor improvements. Merged to master and the 5.4 branch. |
gsmet changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Incorrect Pax URL syntax for bundle (dependency) com.thoughtworks.paranamer/paranamer