Composite key with generated value not working properly #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
DavideD changed the title ![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| CompletionStage<Id> generate(ReactiveConnectionSupplier session, Object entity); | ||
| | ||
| default CompletionStage<Id> generate(ReactiveConnectionSupplier session, Object owner, Object currentValue, EventType eventType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| */ | ||
| CompletionStage<Id> generate(ReactiveConnectionSupplier session, Object entity); | ||
| | ||
| default CompletionStage<Id> generate(ReactiveConnectionSupplier session, Object owner, Object currentValue, EventType eventType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #2154
Rebased #2296 after the upgrade to ORM 7.0.2.Final (that includes hibernate/hibernate-orm#10301)
I squashed together the commits related to the fix, added some assertions to the test, and applied some refactoring