Integration with H2 #1336
Draft
Integration with H2 #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DavideD force-pushed the wip/h2 branch 2 times, most recently from ae5a255 to 7b4f29a Compare 
| We had this error on CI (I need to have a look at it later): |
MySQL always returns an id of type Long. This commit changes an hack that was affecting all dbs and preventing H2 to read identity id of type Integer or Short
Sanne reviewed Jun 22, 2022
| | ||
| @Override | ||
| public String getUri() { | ||
| return "h2:~/test;DATABASE_TO_UPPER=FALSE;DB_CLOSE_DELAY=-1"; |
There was a problem hiding this comment.
This will use an H2 instance baked by a file in the home directory. Could we use an in-memory instance instead?
There was a problem hiding this comment.
Thanks, I will change it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #929
It's a draft because I need to review it