suggested fix for @Fetch(JOIN) problem #7711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @gavinking do you remember what this was about? Searching through Jira about "join" and "fetch" obviously returns hundreds of issues, so I'd appreciate a pointer :) |
| Looking at the code I suppose it is detecting and reporting an inconsistent use of annotations. And I guess I didn’t merge it because I wanted to check with everyone before breaking existing programs which use this (wrong) combination. |
| I will schedule discussing this with the team |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This breaks quite a few tests.
Main issue with it is that
fetch="join"was the way to select eager fetching in.hbm.xml.