HHH-16572 - Incorrect enhancement for PROPERTY attributes with mismatched field and method names #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This first commit is mostly a rough copy of the Without big changes to |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rnate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java Fixed Show fixed Hide fixed
...src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/model/ModelSourceHelper.java Fixed Show fixed Hide fixed
...rnate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java Fixed Show fixed Hide fixed
| * @author Steve Ebersole | ||
| */ | ||
| public class ManagedTypeDescriptorRegistryImpl implements ManagedTypeDescriptorRegistry { | ||
| private final Map<String,ManagedTypeDescriptor> managedTypeDescriptorMap = new LinkedHashMap<>(); |
Check failure
Code scanning / CodeQL
Container contents are never initialized
| | ||
| DynamicType.Builder<?> applyTo(DynamicType.Builder<?> builder) { | ||
| DynamicType.Builder<?> applyTo(DynamicType.Builder<?> builder, ManagedTypeModelContext managedTypeModelContext) { | ||
| final ManagedTypeDescriptor managedTypeDescriptor = managedTypeModelContext.getDescriptorRegistry().resolveDescriptor( managedCtClass.getName() ); |
Check notice
Code scanning / CodeQL
Unread local variable
| return existing; | ||
| } | ||
| | ||
| final ClassDetails classDetails = modelContext.getModelProcessingContext().getClassDetailsRegistry().resolveClassDetails( name ); |
Check notice
Code scanning / CodeQL
Unread local variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-16572