HHH-19876 Enable configuration cache #11132
Open
+362 −327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Description: Helper use Logger directly instead of project.getLogger Spec remove inject, suppress, receive as parameter ObjectFactory and ProjectLayout GrammarDescriptorFactory replace deprecated usage of create with lazy register. TODO this factory can be removed and add callback in plugin to all grammarDescriptors. SplitGrammarDescriptor remove unused field, this is not injected SplitGrammarGenerationTask refactor usage of project, receive ProjectLayout, ProviderFactory and AntlrClasspath injected, use logger of task AntlrPlugin instance AntlrSpec manually and add as extensions.
Description: XjcListenerImpl use Logger directly instead of project.getLogger() XjcTask refactor to make an abstract class and receive inputs and outputs injected
…ion cache projects using hibernate version inject plugin This is an external plugin needs to be updated to be compatible with CC
…ing bnd plugin After bndtools/bnd#6346 is fixed and released, remove this
…ompatible Description: AsciiDocWriter remove unused property project. SettingsDocExtension replace usage of project with objectFactory, remove closure overload is not supported for CC, action is enough. SettingsDocGenerationTask replace usage of project with ObjectFactory and add OrmBuildDetails public lazy set value SettingsDocumentationPlugin update creating of extension and task
Description: AbstractJandexAwareTask add OrmBuildDetails as provider and use ObjectFactory to set, make abstract getIndexManager All subclasses of JandexAwareTask replace usage of project with Layout and ObjectFactory IndexManager change type of artifactsToProcess to ConfigurableFileCollection, add annotations of Input and Outputs, replace usage of Project with ArchiveOperations and Logger to create index, ObjectFactory and Layout in constructor. IndexerTask remove redundant getters with nested property IndexManager, pass ArchiveOperations to create index ReportGenerationPlugin create IndexManager with gradle and pass from configuration jars, add configure for all subtypes of JandexAware, use register instead of maybeCreate task group
…lasses of build details
…ompatible with CC asciidoctor tasks Await stable release of v5 and enable all asciidoctor/asciidoctor-gradle-plugin#756
…d jandexAwareTask
…etails on settings property
…19873 and use explicit function After hibernate#11077 2 warnings are present with missing implementation class for these plugins
…demand in gradle properties
| DON'T MERGE YET. This PR depends on hibernate/version-injection-plugin#5 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19876
https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/Null.20safe.20and.20build.20time