HHH-19857 When one of the lazy attributes is null the other ones may not get initialized correctly #11128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mbellade commented Oct 16, 2025
Comment on lines +1760 to +1764
| /** | ||
| * Used by Hibernate Reactive | ||
| * @deprecated | ||
| */ | ||
| @Deprecated(since = "7.2", forRemoval = true) |
There was a problem hiding this comment.
I have separated the logic that checked which attribute to return (comparing field-names) from the protected boolean initializeLazyProperty method, as they seem unrelated, and the only other thing the latter did is invoke the protected void initializeLazyProperty method which actually sets the initialized value.
I've checked and reactive doesn't seem to be overriding this method anywhere, so perhaps we might even delete it (I've marked it as deprecated for now) since it's no longer used, wdyt @ddalto?
mbellade force-pushed the HHH-19856 branch 2 times, most recently from e57406a to 0040cda Compare 
hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19857
Alternative to #11110, which avoids setting lazy properties multiple times if they're set during the load operation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.