Add To/FromField instances for Const #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
carymrobbins commented Aug 7, 2020
To clarify, I did not commit the reformatted source since it seemed it would have made the PR unnecessarily noisier. PR looks like it should be all good; CI appears to be passing for all targets. |
| @phadej Checking in; anything we can do to get this merged? |
| @phadej Checking back in; any update? |
| Simplified and merged in #53, sorry it took so long. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As the description says, adds
ToFieldandFromFieldinstances forConstviaGeneralizedNewtypeDeriving.I ran
stylish-haskellover the changed files as suggested by theCONTRIBUTING.mdbut it produced a much larger diff as I guess these files haven't been formatted bystylish-haskellin a while, if ever.