Future-proof against potential Prelude.foldl' #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
Collaborator
| Yes, sorry. |
Contributor Author
| @treeowl thanks, CI is green. Does the patch look reasonable? |
Collaborator
| Yes, I think so. |
Contributor Author
| @treeowl could you possibly make a release with this patch please? It would allow to build with GHC HEAD. |
Collaborator
| Yes, I should be able to do that today. |
Contributor Author
| @treeowl just a gentle reminder. |
Collaborator
| Oof... Time got away from me. I'll get to it shortly. …On Wed, Jan 3, 2024, 4:22 PM ˌbodʲɪˈɡrʲim ***@***.***> wrote: @treeowl <https://github.com/treeowl> just a gentle reminder. — Reply to this email directly, view it on GitHub <#480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOOF7M46X7PWPOGBVD47UTYMXDZRAVCNFSM6AAAAAAY2BO2ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVHE4DSMZSGM> . You are receiving this because you were mentioned.Message ID: <haskell-unordered-containers/unordered-containers/pull/480/c1875989323@ github.com> |
Collaborator
| @Bodigrim, I'm sorry that took so long. It's all on Hackage now. |
Contributor Author
| Thanks a lot @treeowl! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See haskell/core-libraries-committee#167
This is, of course, a bit speculative at the moment, but given that the change does not involve CPP, it should not hurt to merge it early to simplify further impact assessment.