Skip to content

Throw on non-200 responses. #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Throw on non-200 responses. #354

wants to merge 1 commit into from

Conversation

@StevenXL
Copy link

@StevenXL StevenXL commented Mar 22, 2019

Replace parseRequest with parseUrlThrow. The latter will throw if the response is does not have a status code of 2xx.
@StevenXL
Copy link
Author

StevenXL commented Mar 22, 2019

This hopefully addresses #353 and #352.
@phadej
Copy link
Contributor

phadej commented Mar 22, 2019

Have you checked that MtStatus, MtRedirect and MtUnit requests work as expected still?
@StevenXL
Copy link
Author

StevenXL commented Mar 22, 2019

I haven’t checked that yet. As soon as I get some time, I’ll check them.
@domenkozar
Copy link
Contributor

domenkozar commented Apr 18, 2019

@phadej what exactly should be checked?
@phadej
Copy link
Contributor

phadej commented Apr 18, 2019

That they don’t throw, as we expect non-200 status codes too
@phadej
Copy link
Contributor

phadej commented May 30, 2019

Fixed in ae57e5f,

MtUnit needed explicit "don't care about status" check.
@phadej phadej closed this May 30, 2019
@StevenXL StevenXL deleted the throw-on-non-200-responses branch May 30, 2019 15:42
@phadej phadej mentioned this pull request May 30, 2019
Closed
@pbrisbin pbrisbin mentioned this pull request Sep 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@StevenXL @phadej @domenkozar