Add note to help users of Session.read and Session.tryRead #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
akshaymankar added a commit to wireapp/wire-server that referenced this pull request Mar 21, 2023
`SSL.read ssl n` doesn't always return `n` bytes, so reading data multiple times is necessary. Upstream PR has been made to warn future users: haskell-cryptography/HsOpenSSL#81
2 tasks
akshaymankar added a commit to wireapp/wire-server that referenced this pull request Mar 21, 2023
* Revert "Revert "Use openssl instead of tls in federator http2 client (#3051)" (#3148)" This reverts commit 615404b. * Ensure that when http2 wants n bytes, we give it n bytes `SSL.read ssl n` doesn't always return `n` bytes, so reading data multiple times is necessary. Upstream PR has been made to warn future users: haskell-cryptography/HsOpenSSL#81 * Add changelog * Remove the IORef read buffer as openssl never returns extra bytes * Read from openssl in tail recursion
vshabanov reviewed Mar 26, 2023
| Thank you, now available in HsOpenSSL-0.11.7.6 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.