Skip to content

Feat: optional backend s3 skip kms key id validation #36730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat: optional backend s3 skip kms key id validation #36730

wants to merge 7 commits into from

Conversation

@lucioreisgh
Copy link

@lucioreisgh lucioreisgh commented Mar 20, 2025 •
edited
Loading

Add skip_kms_key_id_validation Option to S3 Backend

This PR adds the option skip_kms_key_id_validation to the S3 backend.

Skipping the validation allows usage of KMS key IDs that trigger errors due to the regex.

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.
@lucioreisgh
Feat: add optional skip KMS key id validation
ba7dbe6 
Signed-off-by: Lucio Reis <lucioreis@id.uff.br>
@lucioreisgh
Fix skip validation condition + add Backend struct
25f1fa8 
Signed-off-by: Lucio Reis <lucioreis@id.uff.br>
@lucioreisgh
Add changelog entry
e80d6a5 
Signed-off-by: Lucio Reis <lucioreis@id.uff.br>
@lucioreisgh lucioreisgh marked this pull request as ready for review March 20, 2025 15:08
@lucioreisgh lucioreisgh requested review from a team as code owners March 20, 2025 15:08
@lucioreisgh lucioreisgh changed the title F/optional backend s3 skip kms key id validation Feat: optional backend s3 skip kms key id validation Mar 20, 2025
@lucioreisgh lucioreisgh marked this pull request as draft March 20, 2025 15:11
@lucioreisgh lucioreisgh marked this pull request as ready for review March 20, 2025 15:13
@lucioreisgh
Copy link
Author

This PR relates to #34763
@lucioreisgh
Copy link
Author

@crw I have created this PR to try to solve #34763
@crw
Copy link
Contributor

crw commented Mar 20, 2025

Thanks for this submission! It will be up to the HashiCorp AWS provider team to review this PR. Backends typically are not a high priority for review but I have let them know. Thanks!
@svz-ya
Copy link

svz-ya commented May 15, 2025

Thanks for this submission! It will be up to the HashiCorp AWS provider team to review this PR. Backends typically are not a high priority for review but I have let them know. Thanks!

@crw May I ask to send a kind reminder to the team about this PR? This could unblock terraform version upgrade in our environment 🙏
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend/s3 enhancement

3 participants

@lucioreisgh @crw @svz-ya