Skip to content

Fix terraform extract #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpogran merged 11 commits into from
May 9, 2022
Merged

Fix terraform extract #187

jpogran merged 11 commits into from
May 9, 2022

Conversation

@cpc-camarj
Copy link
Contributor

@cpc-camarj cpc-camarj commented Apr 27, 2022

On Windows runners, extracting the downloaded CLI zip file was failing because the file didn't have a .zip extension. This PR attempts to solve the problem by adding the extension to the downloaded file before extraction.

(fixes #186)
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@cpc-camarj
Copy link
Contributor Author

cpc-camarj commented Apr 28, 2022 •
edited
Loading

I identified that I had set a variable to be constant rather than mutable. added a commit to fix that. Validated within a private GitHub workflow this morning that it functions as expected.

(Well, it happens to be morning where I am right now)
@jpogran jpogran self-assigned this Apr 28, 2022
@jpogran jpogran added bug Something isn't working ci labels Apr 28, 2022
@jpogran jpogran added this to the 2.1.0 milestone Apr 28, 2022
@jpogran
Copy link
Contributor

jpogran commented Apr 28, 2022

Thanks for the contribution @cpc-camarj! I'll be able to review this tomorrow, but it looks good so far.
@jpogran
Copy link
Contributor

jpogran commented May 9, 2022

Apologies for the delay in merging. Thank you!
@jpogran jpogran merged commit 8aaee7f into hashicorp:main May 9, 2022
@austinvalle austinvalle modified the milestones: 2.1.0, v3.0.0 Oct 16, 2023
@github-actions
Copy link

github-actions bot commented May 23, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working ci

5 participants

@cpc-camarj @hashicorp-cla @jpogran @cpc-dossaa @austinvalle