Skip to content

Fixing ASCII reader unable to read FD frames #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 30, 2020
Merged

Fixing ASCII reader unable to read FD frames #741

merged 9 commits into from
Jan 30, 2020

Conversation

sou1hacker
Copy link
Contributor

@sou1hacker sou1hacker commented Dec 9, 2019 •
edited by pierreluctg
Loading

CAN FD Frames in an ASCII log file could be logged in the following format:

0.045522 CANFD 62 Rx 7d symbolic_name 1 0 8 8 01 1b d6 d0 8a 1f d7 f6 104812 132 323000 a800f6c9 46500250 4b140250 20011736 2001040d

These frames are currently not read and skipped when using can.LogReader. This PR enables those frames to be read and processed.
Added unit tests for the same.
@codecov
Copy link

codecov bot commented Dec 9, 2019 •
edited
Loading

Codecov Report

Merging #741 into develop will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## develop #741 +/- ## ======================================== Coverage 69.69% 69.69% ======================================== Files 70 70 Lines 6498 6498 ======================================== Hits 4529 4529 Misses 1969 1969
@sou1hacker sou1hacker marked this pull request as ready for review December 9, 2019 19:49
pierreluctg
pierreluctg reviewed Dec 9, 2019
View reviewed changes
@pierreluctg pierreluctg added the file-io about reading & writing to files label Dec 9, 2019
@sou1hacker
Copy link
Contributor Author

@pierreluctg Resolved all comments
@pierreluctg
Copy link
Collaborator

@hardbyte can you please review.

Thank you
@felixdivo
Copy link
Collaborator

felixdivo commented Jan 29, 2020 •
edited
Loading

@pierreluctg can this be merged? I think it looks good.
@felixdivo felixdivo added this to the 4.0 Release milestone Jan 29, 2020
@pierreluctg
Copy link
Collaborator

@felixdivo looks good to me.
@pierreluctg pierreluctg merged commit c92fbc2 into hardbyte:develop Jan 30, 2020
@felixdivo felixdivo mentioned this pull request Feb 1, 2020
Merged
@sou1hacker sou1hacker deleted the asc_fixes branch February 4, 2020 14:10
This was referenced Apr 22, 2020
Closed
Merged
hardbyte pushed a commit that referenced this pull request May 6, 2020
@sou1hacker @hardbyte
Backport #741 - Fixing ASCII reader unable to read FD frames
16d89bc
@felixdivo felixdivo mentioned this pull request Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement file-io about reading & writing to files

3 participants

@sou1hacker @pierreluctg @felixdivo