vector: specify CAN FD support in config detection #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
felixdivo reviewed Jul 15, 2019
Co-Authored-By: Felix Divo <felixdivo@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@ ## develop #641 +/- ## =========================================== + Coverage 63.89% 65.66% +1.76% =========================================== Files 66 65 -1 Lines 5955 5717 -238 =========================================== - Hits 3805 3754 -51 + Misses 2150 1963 -187 |
Codecov Report
@@ Coverage Diff @@ ## develop #641 +/- ## =========================================== + Coverage 63.46% 63.62% +0.15% =========================================== Files 66 66 Lines 6016 6001 -15 =========================================== Hits 3818 3818 + Misses 2198 2183 -15 |
felixdivo approved these changes Jul 15, 2019
| does the bitshift |
Yeah, I guess. (See here) |
| I can only merge this is the formatter approves. @jsee23 Could you fix this? |
karlding added a commit to karlding/python-can that referenced this pull request Oct 1, 2020
Skip any channels that don't have support for CAN (ex. LIN, Digital/Analog IO) instead of accepting everything when using auto-detection. Note: This is a backport of hardbyte#641 to 3.3.4 Addresses hardbyte#908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds the CAN FD support in the config detection for Vector. Additionally, channels without CAN support are skipped.
dict entry is aligned with PCAN backend, see #640.