Skip to content

Add ability to pass explicit dlc value to send() using the SYSTEC interface #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Add ability to pass explicit dlc value to send() using the SYSTEC interface #1756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96611a5
Add ability to pass explicit dlc value to SYSTEC interface when sendi…
dbristow-otc Mar 14, 2024
89a1cf6
run linter
dbristow-otc Mar 15, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions can/interfaces/systec/structures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ class CanMsg(Structure):
), # Receive time stamp in ms (for transmit messages no meaning)
]

def __init__(self, id_=0, frame_format=MsgFrameFormat.MSG_FF_STD, data=None):
def __init__(
self, id_=0, frame_format=MsgFrameFormat.MSG_FF_STD, data=None, dlc=None
):
data = [] if data is None else data
super().__init__(id_, frame_format, len(data), (BYTE * 8)(*data), 0)
dlc = len(data) if dlc is None else dlc
super().__init__(id_, frame_format, dlc, (BYTE * 8)(*data), 0)

def __eq__(self, other):
if not isinstance(other, CanMsg):
Expand Down
1 change: 1 addition & 0 deletions can/interfaces/systec/ucanbus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ def send(self, msg, timeout=None):
| (MsgFrameFormat.MSG_FF_EXT if msg.is_extended_id else 0)
| (MsgFrameFormat.MSG_FF_RTR if msg.is_remote_frame else 0),
msg.data,
msg.dlc,
)
self._ucan.write_can_msg(self.channel, [message])
except UcanException as exception:
Expand Down