Move windows-curses dependency to an optional extra #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## develop #1395 +/- ## =========================================== - Coverage 66.12% 65.25% -0.88% =========================================== Files 86 81 -5 Lines 9066 8767 -299 =========================================== - Hits 5995 5721 -274 + Misses 3071 3046 -25 |
Python 3.11 wheels for windows-curses are [not yet available][1], and this meant that python-can could not be installed on windows with Python 3.11. Since windows-curses is only used in viewer.py, change the dependnecy to an optional extra. [1]: zephyrproject-rtos/windows-curses#31
Hnasar force-pushed the python311-windows branch from 9fa98a5 to 092cf23 Compare 
| Reminder for myself: add this here #1363 |
zariiii9003 approved these changes Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Python 3.11 wheels for windows-curses are not yet available, and this meant that python-can could not be installed on windows with Python 3.11. Since windows-curses is only used in viewer.py, change the dependnecy to an optional extra.
Fixes #1394