Skip to content

Conversation

msalau
Copy link
Contributor

@msalau msalau commented Aug 10, 2022

Hello,

This change allows can.detect_available_configs(['socketcan']) find not just canX and vcanX interfaces, but also slcanX interfaces too. Such names are given by default to interfaces that are created using the slcand utility.

The module has an option to work with SLCAN adapters directly, but creating a SocketCAN interface instead can be beneficial too (e.g.: make it possible to use Wireshark, can-utils, cantools and etc.). For this reason I added few lines to the doc about how to use SLCAN adapters with socketcan.

Regards,
Maksim

@zariiii9003 zariiii9003 requested a review from hartkopp August 11, 2022 07:53
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1369 (d1aafbe) into develop (9d9cb16) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #1369 +/- ## ======================================== Coverage 66.25% 66.25% ======================================== Files 86 86 Lines 9021 9021 ======================================== Hits 5977 5977 Misses 3044 3044 
@msalau
Copy link
Contributor Author

msalau commented Sep 2, 2022

@hartkopp @zariiii9003
Please approve CI so the review can move on eventually :)
All the tests passed in my forked repository (only codecov upload failed due to missing token).

Thanks,
Maksim

@hartkopp
Copy link
Collaborator

hartkopp commented Sep 3, 2022

@hartkopp @zariiii9003 Please approve CI so the review can move on eventually :) All the tests passed in my forked repository (only codecov upload failed due to missing token).

Thanks, Maksim

Looks good to me!
Reviewed-by: Oliver Hartkopp socketcan@hartkopp.net

@zariiii9003 zariiii9003 merged commit ad8b948 into hardbyte:develop Sep 3, 2022
@msalau msalau deleted the find-slcanX-interfaces-in-socketcan branch September 4, 2022 18:42
j-c-cook added a commit to j-c-cook/python-can that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants