Remove redundant writer.stop call that throws error

[j-c-cook]

The issue is that the writer has already previously been told to stop.

The function on_message_received is called:

python-can/can/io/logger.py

Lines 198 to 206 in 796b525

	def on_message_received(self, msg: Message) -> None:
	"""This method is called to handle the given message.
	:param msg:
	the delivered message
	"""
	if self.should_rollover(msg):
	self.do_rollover()
	self.rollover_count += 1

Which calls the self.do_rollover() function

python-can/can/io/logger.py

Lines 333 to 335 in 796b525

	def do_rollover(self) -> None:
	if self.writer:
	self.writer.stop()

. The writer is told to stop:

 def do_rollover(self) -> None: if self.writer: self.writer.stop() sfn = self.base_filename dfn = self.rotation_filename(self._default_name()) self.rotate(sfn, dfn) self._writer = self._get_new_writer(self.base_filename) 

The _get_new_writer function then tells the _writer to close

python-can/can/io/logger.py

Lines 219 to 221 in 796b525

	# Close the old writer first
	if self._writer is not None:
	self._writer.stop()

.

 # Close the old writer first if self._writer is not None: self._writer.stop() 

I believe writer and _writer are linked. So the call to close the _writer is _get_new_writer is redundant and is throwing an error because the writer is no longer open.

closes #1316

[codecov]

Codecov Report

Merging #1317 (9ebdbb8) into develop (4cb2f2f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## develop #1317 +/- ## =========================================== - Coverage 65.98% 65.97% -0.01%  =========================================== Files 86 86 Lines 8948 8946 -2 =========================================== - Hits 5904 5902 -2  Misses 3044 3044 

[zariiii9003]

@felixdivo could you take a look? Can we remove it?

[j-c-cook]

@zariiii9003 Please note that @felixdivo has posted several comments documenting that he is currently unavailable to contribute to the project. (#965 (comment), #1220 (comment)).

I have verified that txt, log, asc, csv and blf all work with the line I removed. However, I have not yet post parsed the output logs to ensure the signal being sent is captured.

[felixdivo]

Yes, this looks good to me. 👍 😄

[zariiii9003]

Yes, this looks good to me. 👍 😄

Thank you! I thought maybe i missed some edge case where it is necessary.