Skip to content

Default mode for FileIOMessageWriter should be wt #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: New BusState members per #736
merged 1 commit into from
May 2, 2022
Merged

Default mode for FileIOMessageWriter should be wt #1303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion can/io/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class FileIOMessageWriter(MessageWriter, metaclass=ABCMeta):

file: can.typechecking.FileLike

def __init__(self, file: can.typechecking.AcceptedIOType, mode: str = "rt") -> None:
def __init__(self, file: can.typechecking.AcceptedIOType, mode: str = "wt") -> None:
# Not possible with the type signature, but be verbose for user-friendliness
if file is None:
raise ValueError("The given file cannot be None")
Expand Down