Skip to content

Conversation

pierreluctg
Copy link
Collaborator

Failure to initiate the Neousys DLL was causing TypeError: %d format: a number is required, not str error since the log line argument is not a number.

@pierreluctg pierreluctg requested a review from felixdivo March 11, 2022 15:38
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1281 (2196750) into develop (ebae360) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## develop #1281 +/- ## ======================================== Coverage 66.02% 66.02% ======================================== Files 86 86 Lines 8915 8915 ======================================== Hits 5886 5886 Misses 3029 3029 
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but such problems should be detected by the test suite. A regression test would probably be a good idea.

@pierreluctg pierreluctg merged commit af55b0a into develop Mar 14, 2022
@pierreluctg pierreluctg deleted the neousys-dll-init branch March 14, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants