Improve gs_usb usability and fix loopback frames #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## develop #1270 +/- ## =========================================== - Coverage 66.02% 66.01% -0.01% =========================================== Files 86 86 Lines 8912 8919 +7 =========================================== + Hits 5884 5888 +4 - Misses 3028 3031 +3 |
| Anything preventing this from being merged? |
Just a lack of active maintainers... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This improves the
gs_usbinterface by adding ability to specify device index instead of USB bus/address. The previous method was really inconvenient, because bus/address changes with each USB enumeration. This required libusb dependency in end applications to scan for adapters.Additionaly, this fixes
is_extended_idand loopback (echo) frames, by correctly markingis_rxflag.