feat: extend IXXAT backend to support CAN-FD #1126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## develop #1126 +/- ## =========================================== + Coverage 70.48% 70.57% +0.08% =========================================== Files 79 79 Lines 7677 7751 +74 =========================================== + Hits 5411 5470 +59 - Misses 2266 2281 +15 |
| TBD: Consider keeping the original implementation based on vcinpl.dll in order to remain backwards-compatible, and introduce IXXAT with vcinpl2 as a new interface? |
| This PR is obviously a duplicate of #1119, following the approach suggested by @zariiii9003 in #1119 (comment). Feel free to close this PR if not required. Thank you. |
semcodech changed the title 
Merged
| Will move forward with #1119 |
| Thanks @ausserlesh |
MattWoodhead added a commit to MattWoodhead/python-can that referenced this pull request Jun 2, 2023
MattWoodhead added a commit to MattWoodhead/python-can that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Introduce CAN-FD support for IXXAT using C-API for CAN-FD vcinpl2.dll.