Small fixes in IXXAT exception handling plus default handling in Bus.__new__ #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… when hardware cannot be initialized
…on. Added two (private) functions to decode error codes
…ing done in canlib). Added VCIRxQueueEmptyError exception
hardbyte approved these changes Dec 21, 2016
can/interfaces/ixxat/canlib.py Outdated
| """ Format a VCI error and attach failed function, decoded HRESULT and arguments | ||
| @TODO: make sure we don't generate another exception | ||
| """ | ||
| buf = ctypes.create_string_buffer(VCI_MAX_ERRSTRLEN) |
Owner
There was a problem hiding this comment.
To avoid repeating the same code just call __vciFormatError here and add the arguments to the returned string.
can/interfaces/ixxat/canlib.py Outdated
| return None | ||
| else: | ||
| raise e | ||
| raise e |
Owner
There was a problem hiding this comment.
Unless you want to add some logging in the event of a VCIError you don't need to catch and re-raise this.
…. Added parameters documentation
Owner
| Thanks Giuseppe |
hardbyte pushed a commit that referenced this pull request Dec 31, 2016
* Added minimal configuration file example and parameters description * Added support for time.perf_counter in python3. * Better error messages when hardware cannot be initialized * Leave the IXXATBus name when importing * Use time.perf_counter only on python releases >= 3.3 * Handle VCI_E_RXQUEUE_EMPTY with explicit VCIRxQueueEmptyError exception. Added two (private) functions to decode error codes * Module does not depend on ctypes to decode error codes anymore (decoding done in canlib). * Added VCIRxQueueEmptyError exception * Improved docstrings * Ignore utf8 decoding error when formatting vci messages Not specific to IXXAT: * Update can.rc from Bus.__new__ kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Exceptions are now simple CanError subclasses and do not depend on ctypes to decode error codes. Decoding is now done in canlib.
Not related to IXXAT but
interface.Bus.__new__was not updating can.rc from its kwargs interface and bitrate.Apply to the develop branch.