Skip to content

Conversation

@gunnarlium
Copy link

This will allow the server to start even when Redis is unavailable. As caching is sometimes just a nice performance enhancement, it can be too drastic to prevent the Hapi-server from start when the cache is unavailable.

GET/SET operations already fail silently for intermittent connection errors.

This should maybe be amended to allow reconnection attempts on startup as well.

@FGRibreau
Copy link

👍 nice addition !

@LoicMahieu LoicMahieu self-assigned this Sep 12, 2016
@LoicMahieu LoicMahieu added this to the v2.0.3 milestone Sep 12, 2016
@LoicMahieu LoicMahieu added the feature New functionality or improvement label Sep 12, 2016
@LoicMahieu
Copy link
Contributor

Hi

Great addition indeed. This is a annoying behavior for us too and I like the idea of being able to set it.
It obviously related to the discussion began by @FGRibreau hapijs/catbox#173

I just made the test, if the client failed to connect at startup, never reconnect ... until the restart the process.
I am trying to look at in redis, but I can't find a way to do reconnect it later.

@gunnarlium
Copy link
Author

Yeah, not too happy about the "single try" approach. Due how the caches are designed, there's no obvious clean way to handle this. But I'd really like to address that issue as well.

@LoicMahieu
Copy link
Contributor

Hi @gunnarlium
catbox-redis@3.0.1 is out. We switch to ioredis for communication with Redis.
I know that ioredis does not hard fail when it could not connect to the server.
So I close the issue but feel free to open a new one if you think the problem is not solved.
Thanks.

@LoicMahieu LoicMahieu closed this Mar 28, 2017
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

3 participants