Mandelbrot fix #310
Merged
Mandelbrot fix #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I've deleted SIMD realization, because it seems that there is no support in D of AVX512-specific instructions currently. Previously when I've made mandelbrot - I've tried 'double8' and it worked (although in documentation only 'double4' is mentioned). I don't know how exactly LDC is figuring out it internally.
| Thanks |
| Thanks for the Broadwell fix, making the comparison fair again.
The vector ops themselves work just fine (and have worked fine with But I guess LLVM vectorizes the loop anyway. Is the runtime diff visible somewhere? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Based on fix from @kinke (PR/308):
I've removed SIMD-specific realization from Mandelbrot.
Because it seems that currently D is not supporting AVX-512 specific instructions.
Now build and tests are passing (at least locally). The time has been increased :(