Create static factory methods for creating Matchers #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For now, starting with FeatureMatcher and TypeSaveDiagnosingMatcher since those are, in my experience, the two most important and commonly used matchers.
This was referenced Aug 25, 2025
| This PR doesn't meet coding formatting standards for the project (it uses tabs for indenting). At the time I submitted this, I didn't have GitHub actions enabled, so I wasn't aware of the formatting enforcement. The formatting is fixed in version of this code incorporated into Hamcrest 4.0 Draft PR #443. |
| Closing this PR, it has been merged in #443 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Starting with FeatureMatcher and TypeSaveDiagnosingMatcher since those are, in my experience, the two most important and commonly used matchers.
I can add more if there are others that should be created.
See Issue #440 .